change encoding of x-amz-copy-source in copy_object

[johnnyvf24]

Hello Minio Team,

Talked with @harshavardhana and it seems the encoding is a bit off for the minio python sdk. It seems the value of the x-amz-copy-source does not need to encode the individual / characters in a provided path.

[johnnyvf24]

Given my bad commits, I'd definitely compress them on merging.

[vadmeste]

@johnnyvf24 I just tested copy_object() and it seems it works fine. Could you say what's specific in your case ?

[johnnyvf24]

@vadmeste how did you test it? I have yet to test AWS, but based on their JS SDK, it seems that the actual slashes are not to be encoded. In my case I am using this python client for a minio instance and a netapp storagegrid S3 compatible service. This client has worked great for everything except for copy object. In my particular case I was trying to copy an object such as sample/path/to/object from one bucket to another in the netapp storage service. At first I thought it was a netapp problem but based on code I have seen from other clients I now think this is a minio-py difference in interpretation of implementation.

[johnnyvf24]

@vadmeste any update on this?

[harshavardhana]

@johnnyvf24 I just tested copy_object() and it seems it works fine. Could you say what's specific in your case ?

The issue is with NetApp Storage Grid which is not forthcoming in its parsing of x-amz-copy-source here, although there is no need to convert / to be %2F it was implicitly done by minio-py which sort of breaks NetApp Storage Grid product.

NOTE: without this change minio-py works fine with MinIO and AWS S3 because of both support %2F as well automatically.

But it doesn't hurt to fix minio-py

[kannappanr]

LGTM