Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor sse.py to fix pylint errors. #918

Merged
merged 1 commit into from
May 18, 2020
Merged

refactor sse.py to fix pylint errors. #918

merged 1 commit into from
May 18, 2020

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana force-pushed the fix-pylint-errors-in-sse-py branch 4 times, most recently from cd15efb to c542c67 Compare May 8, 2020 06:09
kannappanr
kannappanr previously approved these changes May 10, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr requested a review from vadmeste May 10, 2020 00:14
@kannappanr
Copy link
Collaborator

Please resolve conflicts

@balamurugana balamurugana force-pushed the fix-pylint-errors-in-sse-py branch 2 times, most recently from 64578bc to aa19ef1 Compare May 10, 2020 06:01
kannappanr
kannappanr previously approved these changes May 10, 2020
View reviewed changes
@balamurugana balamurugana force-pushed the fix-pylint-errors-in-sse-py branch 2 times, most recently from cfc6dbc to 528a967 Compare May 10, 2020 19:14
kannappanr
kannappanr previously approved these changes May 10, 2020
View reviewed changes
@balamurugana balamurugana force-pushed the fix-pylint-errors-in-sse-py branch 2 times, most recently from c2997f5 to 29f64b3 Compare May 15, 2020 06:46
kannappanr
kannappanr previously approved these changes May 15, 2020
View reviewed changes
kannappanr
kannappanr approved these changes May 15, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 13d3965 into minio:master May 18, 2020
@balamurugana balamurugana deleted the fix-pylint-errors-in-sse-py branch May 18, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@kannappanr kannappanr kannappanr approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

@anjalshireesh anjalshireesh Awaiting requested review from anjalshireesh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@balamurugana @kannappanr @harshavardhana