Less memory allocation with put_object() #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
previously approved these changes
Jun 18, 2020
put_object() allocates more memory than what we would expect. The reason is that workers upload parts while the main code allocates memory from the new parts that are being read from the source stream A semaphore is used in add_task() to make this latter blocking. That way, the main code won't hurry to allocate new memory space for the new data of the source stream.
harshavardhana
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
put_object() allocates more memory than what we would expect. The
reason is that workers upload parts while the main code allocates
memory for the new parts that are being read from the source stream.
A semaphore is used in add_task() to make this latter blocking. That
way, the main code won't hurry to allocate new memory space for the
new data of the source stream.
Fixes #929