Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: deprecate logger log levels #3927

Closed
harshavardhana opened this issue Mar 18, 2017 · 7 comments · Fixed by #3938
Closed

config: deprecate logger log levels #3927

harshavardhana opened this issue Mar 18, 2017 · 7 comments · Fixed by #3938
Assignees

Comments

@harshavardhana
Copy link
Member

  • remove 'log-level' for loggers.
  • rename fileName for file logger as filename.

migrate the config to version 16.

Expected Behavior

Currently log-levels are kind of pretty much useless because we do not have any extensive logging.

Current Behavior

log-levels are supported and parsed which do not provide much value to the end user and ends up confusing them.

Possible Solution

Fix config.json

Steps to Reproduce (for bugs)

Open config.json

Context

Cleanup and simplification.

Your Environment

Latest minio release and master branch.

@balamurugana
Copy link
Member

balamurugana commented Mar 18, 2017

Currently log-levels are kind of pretty much useless because we do not have any extensive logging.

What if I want to save <= fatal log level in a separate file target?

@harshavardhana
Copy link
Member Author

What if I want to save <= fatal log level in a separate file target?

Most deployments do not even touch these values + they are not adding value anymore since we don't have egregious log-levels in our codebase. Just one less thing to document and explain.

We can easily ignore that case..

@balamurugana
Copy link
Member

Ignoring will lead to bloated log file in a long run. Another case is, if we support other log targets, user may like to save certain log levels to different target.

@harshavardhana
Copy link
Member Author

Ignoring will lead to bloated log file in a long run. Another case is, if we support other log targets, user may like to save certain log levels to different target.

When it happens we will bring whatever is necessary at that point in time. There are not open requirements for now.

@vadmeste
Copy link
Member

@harshavardhana what will be the default log value internally in the code ?

@harshavardhana
Copy link
Member Author

@harshavardhana what will be the default log value internally in the code ?

there is no log-level all log-levels are enabled.. @vadmeste

@lock
Copy link

lock bot commented May 6, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants