-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Healthcheck fails on latest Minio release Docker image #5010
Comments
Same problem here. However the "fix" will not work for me as the health check is performed by an external tool. I guess this will hit a lot of people using external tools like Nagios. |
Do not understand what you are talking about here @dswd |
This fix has nothing to do with nagios, for nagios monitoring you should write your own plugin using admin REST API. In this fix healthcheck is a concept of docker containers which happily accepts external tools, one such example scripts used https://github.com/docker-library/healthcheck |
Ok to clarify: I need a simple unauthorized URL that can be used for a health check by an external tool. |
If you require unauthorized, then you can add a User-Agent since you are already using an external tool. There are no unauthorized endpoints on Minio other than browser. |
Exactly that is my problem. The external tool has no support for adding a fake user-agent to the request. Could you consider restoring the original behavior of minio? |
Original behavior was wrong its the same reason why our docker healthscript stopped working. @dswd what is the external tool that is being used which cannot take a user-agent? |
The external tool I am talking about is the integrated health check of Cloudron.io. I am maintaining the Minio app on that platform. |
Do you have the code for this App that we can take a look? @dswd |
Ich already sent a PR to that project but that will take some weeks. Until then the current minio will not be available. |
Same Problem here. Hashicorp's nomad health check needs an unauthorized http request with a 2xx ranged reply. See here: https://www.nomadproject.io/docs/job-specification/service.html#check-parameters. I believe an unauthorized dedicated /health endpoint would be useful. |
We are using minio on Rancher, which also needs any kind of 2xx response from an unauthorized endpoint. |
+1 for simple /health endpoint. Would make writing Kubernetes readiness/live probes much easier. |
The docker state still shows unhealthy, however. Should I just manually change healthcheck.sh until it gets fixed? No rush in my case, it's just aesthetic for me as I'm not monitoring (it's for a personal project). Many thanks. |
Nevermind. I see it's being handled in #6365 |
@yebo29 The issue has been fixed in RELEASE.2018-09-01T00-38-25Z: https://github.com/minio/minio/tree/RELEASE.2018-09-01T00-38-25Z |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Expected Behavior
Docker should report the status of Minio container as healthy
Current Behavior
Docker reports the status as unhealthy
Possible Solution
Fix
healthcheck.sh
Steps to Reproduce (for bugs)
docker ps
.Context
Your Environment
minio version
):uname -a
):The text was updated successfully, but these errors were encountered: