Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unsupported object ACL header? #5706

Closed
GeoffreyBooth opened this issue Mar 26, 2018 · 10 comments · Fixed by #5906
Closed

Ignore unsupported object ACL header? #5706

GeoffreyBooth opened this issue Mar 26, 2018 · 10 comments · Fixed by #5906

Comments

@GeoffreyBooth
Copy link

I’m trying to use Minio to emulate S3 for an application I’m developing. My app uses a library to upload files/put objects into S3, and I don’t have much control over it. Unfortunately it applies an object-level ACL to every file uploaded, which I know Minio doesn’t support (#4496).

My issue is that Minio returns a 501 error, A header you provided implies functionality that is not implemented, on such attempted uploads. Would it be possible for Minio to just ignore this unsupported header? Possibly via configuration?

@harshavardhana
Copy link
Member

harshavardhana commented Mar 26, 2018

We will have to discuss this since ignoring it would mean that we are falsely representing the API and behavior. IMO we should avoid doing such things as it might provide a false representation of API for applications and even cause them to expect a certain type of behavior which will be fake.

Please do let us know what is the library you are using we can recommend changes, ACL is considered legacy style and is a legacy way to apply policy on a bucket which lacks flexibility.

@GeoffreyBooth
Copy link
Author

Please do let us know what is the library you are using we can recommend changes, ACL is considered legacy style and is a legacy way to apply policy on a bucket which lacks flexibility.

I know, I’ve investigated patching it but unfortunately I haven’t been able to. It’s a closed-source proprietary app called OpenText Media Management. They only just added S3 support a few months ago, and yes, they’re using this deprecated API. That pretty much tells you all you need to know about their software (and no, I can’t stop using it).

Maybe a global configuration setting like “ignore unsupported APIs” or “ignore unsupported headers”? That would be disabled by default, to preserve the current behavior, but cases like mine could set this in order to override Minio’s validation.

@harshavardhana
Copy link
Member

Maybe a global configuration setting like “ignore unsupported APIs” or “ignore unsupported headers”? That would be disabled by default, to preserve the current behavior, but cases like mine could set this in order to override Minio’s validation.

Will let you know we can perhaps provide an unsafe mode @GeoffreyBooth

@nitisht nitisht added this to the Next Release milestone Mar 26, 2018
@harshavardhana
Copy link
Member

harshavardhana commented Apr 6, 2018

This needs to be discussed @deekoder - moving this to blocked for discussion.

@deekoder
Copy link
Contributor

deekoder commented May 8, 2018

@harshavardhana will be sending PR for this soon.

@harshavardhana
Copy link
Member

@GeoffreyBooth we will be supporting GetBucketACL as a dummy call for now which perhaps should resolve legacy application problems. Will be sending a PR on this shortly.

harshavardhana added a commit to harshavardhana/minio that referenced this issue May 9, 2018
GetBucketACL call simply returns empty for all GET
in ACL requests, the primary purpose of this PR
is simply to provide legacy API support for
legacy applications.

Fixes minio#5706
harshavardhana added a commit to harshavardhana/minio that referenced this issue May 9, 2018
GetBucketACL call simply returns empty for all GET
in ACL requests, the primary purpose of this PR
is simply to provide legacy API support for
legacy applications.

Fixes minio#5706
harshavardhana added a commit to harshavardhana/minio that referenced this issue May 9, 2018
GetBucketACL call simply returns empty for all GET
in ACL requests, the primary purpose of this PR
is simply to provide legacy API support for
legacy applications.

Fixes minio#5706
@harshavardhana
Copy link
Member

@GeoffreyBooth we have a PR here would you be able to validate it with your application? #5906 ?

harshavardhana added a commit to harshavardhana/minio that referenced this issue May 9, 2018
GetBucketACL call simply returns empty for all GET
in ACL requests, the primary purpose of this PR
is simply to provide legacy API support for
legacy applications.

Fixes minio#5706
harshavardhana added a commit to harshavardhana/minio that referenced this issue May 9, 2018
GetBucketACL call simply returns empty for all GET
in ACL requests, the primary purpose of this PR
is simply to provide legacy API support for
legacy applications.

Fixes minio#5706
nitisht pushed a commit that referenced this issue May 10, 2018
GetBucketACL call returns empty for all GET in ACL requests, 
the primary purpose of this PR is to provide legacy API support 
for legacy applications.

Fixes #5706
@nitisht nitisht added the fixed label May 10, 2018
@GeoffreyBooth
Copy link
Author

Not quickly, sorry.

@harshavardhana
Copy link
Member

Not quickly, sorry.

@GeoffreyBooth you can try now docker pull minio/minio:edge

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants