fix: make sure to use uniform drive count calculation #10208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
fix-drive-count
branch
from
f7270c7
to
1bbfe7f
Compare
kannappanr
requested review from
poornas,
vadmeste,
kannappanr and
krishnasrinivas
harshavardhana
force-pushed
the
fix-drive-count
branch
from
1bbfe7f
to
eea3419
Compare
poornas
approved these changes
Aug 5, 2020
harshavardhana
force-pushed
the
fix-drive-count
branch
from
eea3419
to
7794613
Compare
It is possible in situations when server was deployed
in asymmetric configuration in the past such as
```
minio server ~/fs{1...4}/disk{1...5}
```
Results in setDriveCount of 10 in older releases
but with fairly recent releases we have moved to
having server affinity which means that a set drive
count ascertained from above config will be now '4'
While the object layer make sure that we honor
`format.json` the storageClass configuration however
was by mistake was using the global value obtained
by heuristics. Which leads to prematurely using
lower parity without being requested by the an
administrator.
This PR fixes this behavior.
harshavardhana
force-pushed
the
fix-drive-count
branch
from
7794613
to
9fc2500
Compare
Mint Automation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: make sure to use uniform drive count calculation
Motivation and Context
It is possible in situations when server was deployed
in asymmetric configuration in the past such as
Results in setDriveCount of 10 in older releases
but with fairly recent releases we have moved to
having server affinity which means that a set drive
count ascertained from above config will be now '4'
While the object layer make sure that we honor
format.jsonthe storageClass configuration howeverwas by mistake was using the global value obtained
by heuristics. Which leads to prematurely using
lower parity without being requested by the an
administrator.
This PR fixes this behavior.
How to test this PR?
Download MinIO from like 02-27 and start the server with
minio server ~/fs{1...4}/disk{1...5}create few objects and then upgrade the server to latest release - now try to set the storage
class
mc admin config set myminio/ storage_class standard=EC:4you will see an error.We shouldn't have that error in the first place, this PR fixes this behavior. We need to make
a release with this fix as soon as it's merged.
Types of changes
Checklist:
commit-idorPR #here)