New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add public certs automatically as part of global CAs #10256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mint Automation
10256-5c00f7c/mint-gateway-azure.sh.log:
10256-5c00f7c/mint-gateway-s3.sh.log:
Deleting image on docker hub |
aead
approved these changes
Aug 13, 2020
Alevsk
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: add public certs automatically as part of global CAs
Motivation and Context
no need to drop the same
public.crt
into CAs folderif it can be automatically added to global CAs
How to test this PR?
Just create
public,crt
andprivate.key
with wildcard certfor all server nodes in a tenant, there is no need to copy
this public.crt again to CAs folder.
Types of changes
Checklist:
commit-id
orPR #
here)