New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rootDisk on containers can have different device Id #10259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use `/etc/hosts` instead of `/` to check for common device id, if the device is same for `/etc/hosts` and the --bind mount to detect root disks. Bonus enhance healthcheck logging by adding maintenance tags, for all messages.
kannappanr
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
krishnasrinivas
approved these changes
Aug 13, 2020
Mint Automation
10259-892b05b/mint-gateway-azure.sh.log:
10259-892b05b/mint-gateway-s3.sh.log:
Deleting image on docker hub |
harshavardhana
added a commit
that referenced
this pull request
Aug 13, 2020
use `/etc/hosts` instead of `/` to check for common device id, if the device is same for `/etc/hosts` and the --bind mount to detect root disks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rootDisk on containers can have different device Id
Motivation and Context
use
/etc/hosts
instead of/
to check for commondevice id, if the device is the same for
/etc/hosts
and the --bind mount to detect root disks.
Bonus enhance healthcheck logging by adding maintenance
tags, for all messages.
How to test this PR?
Test with mounted disks with one of them being root partition
Types of changes
Checklist:
commit-id
orPR #
here)