New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validation logs for configured Logger/Audit HTTP targets #10274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
extra-logs
branch
from
August 15, 2020 20:47
c5aa87e
to
abdbdb8
Compare
poornas
approved these changes
Aug 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
extra logs in-case of misconfiguration of audit/logger targets
harshavardhana
force-pushed
the
extra-logs
branch
from
August 16, 2020 06:44
abdbdb8
to
a819c4e
Compare
Mint Automation
10274-a819c4e/mint-gateway-s3.sh.log:
10274-a819c4e/mint-gateway-azure.sh.log:
Deleting image on docker hub |
kannappanr
approved these changes
Aug 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add validation logs for configured Logger/Audit HTTP targets
Motivation and Context
extra logs in-case of misconfiguration of audit/logger targets
How to test this PR?
Types of changes
Checklist:
commit-id
orPR #
here)