New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bring back delayed leaf detection in listing #10346
Conversation
ab9c640
to
8f9c04a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
8f9c04a
to
9dc4b9d
Compare
9dc4b9d
to
612a757
Compare
NOTE: The entire code is actually from previous implementation of Walkers() when they used These unit tests have been captured over the years in checking various corner cases which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think I understand it but I assume you vouch for correctness (along with existing tests)
Few minor things.
be17f6b
to
8d8a227
Compare
Mint Automation
10346-9dc4b9d/mint-gateway-azure.sh.log:
Deleting image on docker hub |
Description
fix: bring back delayed leaf detection in listing
Motivation and Context
improve List performance
How to test this PR?
No functionality should change
Types of changes
Checklist:
commit-id
orPR #
here)