Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use constants for gateway names #10355

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

flysnoworg
Copy link
Contributor

Description

Unified gateway name

Motivation and Context

Use constants for gateway names to avoid bugs caused by spelling.

How to test this PR?

No need

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed

cmd/gateway-interface.go Outdated Show resolved Hide resolved
cmd/gateway-interface.go Outdated Show resolved Hide resolved
cmd/gateway-interface.go Outdated Show resolved Hide resolved
@minio minio deleted a comment from minio-trusted Aug 26, 2020
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-zoned.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally
Error: No such image: minio/minio:10355-41f3f02

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit ea18034 into minio:master Aug 26, 2020
@flysnoworg flysnoworg deleted the unified-gateway-name branch August 27, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants