Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify webhook DNS further generalize for gateway #10448

Merged
merged 1 commit into from Sep 10, 2020

Conversation

harshavardhana
Copy link
Member

Description

simplify webhook DNS further generalize for gateway

Motivation and Context

continuation of the changes from eaaf05a
this further simplifies, enables this for gateway deployments as well

How to test this PR?

Nothing specific adds more information for the administrator, also enables
the feature for gateway deployments.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed

continuation of the changes from eaaf05a
this further simplifies, enables this for gateway deployments as well
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-zoned.sh ✔️
mint-gateway-nas.sh ✔️
mint-gateway-azure.sh more...

10448-90b5a53/mint-gateway-azure.sh.log:

Running with
SERVER_ENDPOINT:      minio-dev8.minio.io:31958
ACCESS_KEY:           minioazure
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 3dcaef683428:/mint/log /tmp/mint-logs'

(1/15) Running aws-sdk-go tests ... done in 7 seconds
(2/15) Running aws-sdk-java tests ... done in 2 seconds
(3/15) Running aws-sdk-php tests ... done in 1 minutes and 6 seconds
(4/15) Running aws-sdk-ruby tests ... done in 18 seconds
(5/15) Running awscli tests ... FAILED in 46 seconds
{
  "name": "awscli",
  "duration": 3966,
  "function": "aws --endpoint-url http://minio-dev8.minio.io:31958 s3api copy-object --bucket awscli-mint-test-bucket-26253 --key datafile-1-kB-copy --copy-source awscli-mint-test-bucket-26253/datafile-1-kB\n",
  "status": "FAIL",
  "error": "Hash mismatch expected a861ac626e0bee4421a50737c581233c, got 0x8D8550CD79E96E3-1"
}
(5/15) Running healthcheck tests ... done in 0 seconds
(6/15) Running mc tests ... done in 3 minutes and 57 seconds
(7/15) Running minio-dotnet tests ... done in 1 minutes and 33 seconds
(8/15) Running minio-go tests ... done in 6 minutes and 7 seconds
(9/15) Running minio-java tests ... done in 7 minutes and 32 seconds
(10/15) Running minio-js tests ... done in 2 minutes and 32 seconds
(11/15) Running minio-py tests ... done in 13 minutes and 21 seconds
(12/15) Running s3cmd tests ... done in 2 minutes and 20 seconds
(13/15) Running s3select tests ... done in 58 seconds
(14/15) Running security tests ... done in 0 seconds

Executed 14 out of 15 tests successfully.

Deleting image on docker hub
Deleting image locally
Error: No such image: minio/minio:10448-90b5a53

Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & Tested with Operator

@harshavardhana
Copy link
Member Author

PTAL @kerneltime

@harshavardhana harshavardhana merged commit eb2934f into minio:master Sep 10, 2020
@harshavardhana harshavardhana deleted the fix-dns branch September 10, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants