Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix healing delete marker #10530

Merged
merged 4 commits into from Sep 21, 2020
Merged

Fix healing delete marker #10530

merged 4 commits into from Sep 21, 2020

Conversation

vadmeste
Copy link
Member

@vadmeste vadmeste commented Sep 21, 2020

Description

Healing was not working correctly in distributed mode because
errFileVersionNotFound was not properly converted in storage rest
client.

Besides, fixing healing delete marker is not working as expected.

Motivation and Context

Fix healing in versioning mode

How to test this PR?

  1. Start a distributed setup, 4 nodes, 4 disks
  2. Create a versioning bucket
  3. Upload a file
  4. Kill one node
  5. Remove the file
  6. Start the node again
    Test 1:
    mc admin heal -r --scan=deep command and mc ls --versions multiple times
    Test 2:
    Remove the object in disk 1, mc admin heal -r scan=deep, repeat with disk 2, 3 and 4 and check the integrity of the file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed

Healing was not working correctly in distributed mode because
errFileVersionNotFound was not properly converted in storage rest
client.

Besides, fixing healing delete marker is not working as expected.
@vadmeste vadmeste changed the title [WIP] Fix healing delete marker Fix healing delete marker Sep 21, 2020
@vadmeste vadmeste marked this pull request as ready for review September 21, 2020 21:06
cmd/xl-storage.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
vadmeste and others added 3 commits September 21, 2020 22:10
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
@harshavardhana harshavardhana merged commit 4c81201 into minio:master Sep 21, 2020
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-gateway-nas.sh ✔️
mint-zoned.sh more...

10530-712dc22/mint-zoned.sh.log:

Running with
SERVER_ENDPOINT:      minio-dev8.minio.io:32321
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp d66845efeb9b:/mint/log /tmp/mint-logs'

(1/15) Running aws-sdk-go tests ... done in 4 seconds
(2/15) Running aws-sdk-java tests ... done in 1 seconds
(3/15) Running aws-sdk-php tests ... done in 45 seconds
(4/15) Running aws-sdk-ruby tests ... done in 6 seconds
(5/15) Running awscli tests ... done in 2 minutes and 7 seconds
(6/15) Running healthcheck tests ... done in 0 seconds
(7/15) Running mc tests ... done in 50 seconds
(8/15) Running minio-dotnet tests ... done in 56 seconds
(9/15) Running minio-go tests ... done in 1 minutes and 57 seconds
(10/15) Running minio-java tests ... done in 1 minutes and 32 seconds
(11/15) Running minio-js tests ... done in 52 seconds
(12/15) Running minio-py tests ... done in 3 minutes and 33 seconds
(13/15) Running s3cmd tests ... FAILED in 21 seconds
{
  "name": "s3cmd",
  "duration": "9588",
  "function": "test_sync_list_objects",
  "status": "FAIL",
  "error": "WARNING: Bucket is not empty. Removing all the objects from it first. This may take some time...\nERROR: S3 error: 404 (Not Found)"
}
(13/15) Running s3select tests ... done in 10 seconds
(14/15) Running security tests ... done in 0 seconds

Executed 14 out of 15 tests successfully.

Deleting image on docker hub
Deleting image locally
Error: No such image: minio/minio:10530-712dc22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants