-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the maximum open connections limit in PG and MySQL target configs #10558
Set the maximum open connections limit in PG and MySQL target configs #10558
Conversation
Can we add |
Yes we can @Praveenrajmani |
As the bulk/recursive delete will require multiple connections to open at an instance, The default open connections limit will be reached which results in the following error ```FATAL: sorry, too many clients already``` By setting the open connections to a reasonable value - `2`, We ensure that the max open connections will not be exhausted and lie under bounds. The queries are simple inserts/updates/deletes which is operational and sufficient with the maximum open connection limit being 2. Fixes minio#10553
b0ee1e8
to
d08c906
Compare
The PR is ready for review. PTAL @harshavardhana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mint Automation
10558-57b9edc/mint-gateway-azure.sh.log:
Deleting image on docker hub |
Description
As the bulk/recursive delete will require multiple connections to open at once,
The default open connections limit will be reached which results in the following error
FATAL: sorry, too many clients already
By setting the open connections to a reasonable value -
2
, We ensure that the max open connectionswill not be exhausted and lie under bounds.
The queries are simple inserts/updates/deletes which is operational and sufficient with the
maximum open connection limit being 2.
Motivation and Context
Fixes #10553
How to test this PR?
The steps are provided in #10554
Types of changes
Checklist:
commit-id
orPR #
here)