-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minimum replication workers started #10560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Sep 24, 2020
eco-minio
requested changes
Sep 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single minor change
poornas
force-pushed
the
numworkers
branch
2 times, most recently
from
September 24, 2020 18:05
1cc9083
to
141e205
Compare
This PR also fixes GetReplicationConfiguration permission in web-handlers.go to use bucket as resource
harshavardhana
approved these changes
Sep 24, 2020
harshavardhana
approved these changes
Sep 24, 2020
eco-minio
approved these changes
Sep 24, 2020
Mint Automation
10560-1cc9083/mint-zoned.sh.log:
10560-1cc9083/mint-gateway-azure.sh.log:
Deleting image on docker hub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Replication should not fail to start workers even in a test setup with one cpu, though replication essentially needs its own thread
Also fixing permissions issue in web-handlers.go for checking if user has GetReplicationConfiguration permission.
How to test this PR?
Types of changes
Checklist:
commit-id
orPR #
here)