New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate bucket metacache if corrupted #10800
Merged
harshavardhana
merged 2 commits into
minio:master
from
klauspost:recreate-metacache-on-quorum-read-err
Oct 31, 2020
Merged
Recreate bucket metacache if corrupted #10800
harshavardhana
merged 2 commits into
minio:master
from
klauspost:recreate-metacache-on-quorum-read-err
Oct 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If bucket metadata cannot be read, clean up existing and create a new.
klauspost
force-pushed
the
recreate-metacache-on-quorum-read-err
branch
from
October 31, 2020 12:00
470bd66
to
785b493
Compare
harshavardhana
approved these changes
Oct 31, 2020
Mint Automation
10800-2bb36aa/mint-gateway-azure.sh.log:
10800-2bb36aa/mint-dist-erasure.sh.log:
Deleting image on docker hub |
kannappanr
approved these changes
Oct 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If bucket metadata cannot be read, clean up existing and create a new.
Motivation and Context
If bucket metadata ended up with a read quorum error there was no automatic recovery.
Cleanup will remove any leftover data from the lost cache information.
How to test this PR?
Make the
.minio.sys/buckets/BUCKET/.metacache/index.s2
impossible to read.Types of changes