New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename OBD to Health #10842
Merged
Merged
Rename OBD to Health #10842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjalshireesh
force-pushed
the
subnet
branch
7 times, most recently
from
November 6, 2020 09:39
b903bde
to
159b1e6
Compare
anjalshireesh
requested review from
harshavardhana,
abperiasamy and
kannappanr
November 6, 2020 10:51
anjalshireesh
force-pushed
the
subnet
branch
2 times, most recently
from
November 9, 2020 16:43
d19c14e
to
013bf4b
Compare
wlan0
approved these changes
Nov 10, 2020
Also, Remove threadstats and openfds from health report as we already have process stats and numfds
anjalshireesh
force-pushed
the
subnet
branch
from
November 10, 2020 09:11
013bf4b
to
493da0b
Compare
Mint Automation
10842-1ab45da/mint-gateway-azure.sh.log:
10842-1ab45da/mint-large-bucket.sh.log:
Deleting image on docker hub |
harshavardhana
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OBD
withHealth
in structure/function names wherever appropriateOBD
from structure/function names wherever not requiredadmin:OBDInfo
as it can disrupt existing deployments.A new policy
admin:HealthInfo
can be added in a separate PR and the old one canbe removed at a later date after giving sufficient notice to the community
Motivation and Context
As the
mc admin obd
command has been renamed tomc admin subnet health
,removing all references to
OBD
and replacing withhealth
wherever appropriate.Also removing
threadstats
andopenfds
from the process info as these tend to bever large and we already have have process stats and
numfds
How to test this PR?
Subnet health report (
mc admin subnet health
) should continue to work fine.Types of changes
Checklist:
commit-id
orPR #
here)