-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delete marker replication should support directories #10878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
fix-hangs
branch
from
November 11, 2020 20:40
8b40a59
to
1d6e85f
Compare
poornas
reviewed
Nov 11, 2020
kannappanr
approved these changes
Nov 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
harshavardhana
force-pushed
the
fix-hangs
branch
2 times, most recently
from
November 12, 2020 04:29
0f2875e
to
b232b96
Compare
build failure. Haven't been able to repro the issue you saw, however ok with the other fixes in the PR. |
poornas
approved these changes
Nov 12, 2020
allow directories to be replicated as well, along with their delete markers in replication. Bonus fix to fix bloom filter updates for directories to be preserved.
harshavardhana
force-pushed
the
fix-hangs
branch
from
November 12, 2020 06:31
b232b96
to
a8e86f2
Compare
harshavardhana
changed the title
fix: multi-object delete would hang after 10,000 entries
fix: delete marker replication should support directories
Nov 12, 2020
Mint Automation
10878-a4c8ed2/mint-gateway-azure.sh.log:
Deleting image on docker hub |
harshavardhana
added a commit
that referenced
this pull request
Nov 20, 2020
allow directories to be replicated as well, along with their delete markers in replication. Bonus fix to fix bloom filter updates for directories to be preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: delete marker replication should support directories
Motivation and Context
allow directories to be replicated as well, along with
their delete markers in replication.
Bonus fix to fix bloom filter updates for directories
to be preserved.
How to test this PR?
Nothing special create delete markers for directories and see
if they are replicated properly.
Types of changes
Checklist:
commit-id
orPR #
here)