Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for replication of object tags, retention metadata #10880

Merged
merged 1 commit into from Nov 19, 2020
Merged

Add support for replication of object tags, retention metadata #10880

merged 1 commit into from Nov 19, 2020

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Nov 12, 2020 •
edited

Description

Motivation and Context

replication of object tags and retention/legal hold metdata currently missing functionality

How to test this PR?

mc cp on a replication enabled bucket, then mc tag set on a version or mc retention

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed

@poornas poornas mentioned this pull request Nov 12, 2020
Merged
@harshavardhana harshavardhana changed the base branch from master to dev November 12, 2020 20:14
@poornas poornas changed the title Add support for replication of object tags Add support for replication of object tags, retention metadata Nov 18, 2020
@poornas poornas requested review from kannappanr and cesnietor and removed request for kannappanr November 18, 2020 23:24
cesnietor
cesnietor approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested adding/removing tags/legalhold works well.

@minio minio deleted a comment from minio-trusted Nov 19, 2020
harshavardhana
harshavardhana requested changes Nov 19, 2020
View reviewed changes
cmd/data-crawler.go Outdated Show resolved Hide resolved
cmd/erasure-object.go Outdated Show resolved Hide resolved
harshavardhana
harshavardhana requested changes Nov 19, 2020
View reviewed changes
cmd/bucket-replication.go Outdated Show resolved Hide resolved
cmd/bucket-replication.go Outdated Show resolved Hide resolved
cmd/bucket-replication.go Outdated Show resolved Hide resolved
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-zoned.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit fbe844b into minio:dev Nov 19, 2020
harshavardhana pushed a commit that referenced this pull request Nov 20, 2020
@poornas @harshavardhana
Add support for replication of object tags, retention metadata (#10880)
251c1ef
@poornas poornas deleted the reptags branch June 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@cesnietor cesnietor cesnietor approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@poornas @minio-trusted @harshavardhana @cesnietor