-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crawler: Stream bucket usage cache data #11068
crawler: Stream bucket usage cache data #11068
Conversation
Stream bucket caches to storage and through rpc calls. Untested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to test this, until then 👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data usage crawl seems to return an error with this change
API: SYSTEM()
Time: 22:54:55 PST 12/09/2020
DeploymentID: 4a0e8c8b-3c6f-4fae-9bb8-3b3dca1610fc
Error: unexpected filler byte: 3 (*errors.errorString)
1: /home/kp/code/src/github.com/minio/minio/cmd/erasure.go:375:cmd.erasureObjects.crawlAndGetDataUsage.func2()
Mint Automation
11068-13dd98c/mint-gateway-azure.sh.log:
Deleting image on docker hub |
@poornas Thanks. Yes, found the bugs with the streaming reponse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested
Stream bucket caches to storage and through RPC calls.
Description
Stream bucket caches to storage and through rpc calls.
How to test this PR?
Tested, now.
Types of changes