-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lifecycle improvements and additional debug logging #11096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested review from
kanagarajkm,
kannappanr and
kaankabalak
December 13, 2020 03:50
harshavardhana
force-pushed
the
update-browser
branch
from
December 13, 2020 06:56
9dc04d8
to
ddba114
Compare
harshavardhana
force-pushed
the
update-browser
branch
from
December 13, 2020 07:43
ddba114
to
4979c98
Compare
Mint Automation
11096-4979c98/mint-gateway-azure.sh.log:
Deleting image on docker hub |
harshavardhana
changed the title
update browser assets to fix vulnerabilities
lifecycle improvements and additional debug logging
Dec 13, 2020
harshavardhana
requested review from
poornas and
vadmeste
and removed request for
kanagarajkm
December 13, 2020 09:59
kannappanr
approved these changes
Dec 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lifecycle improvements and additional debug logging
Bonus change fix browser assets.
Motivation and Context
lifecycle improvements and additional debug logging
How to test this PR?
Avoid duplicate events for transitioned objects
Types of changes
Checklist:
commit-id
orPR #
here)