-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: load credentials from etcd directly when possible #11339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
under large deployments loading credentials might be time consuming, while this is okay and we will not respond quickly for `mc admin user list` like queries but it is possible to support `mc admin user info` just like how we handle authentication by fetching the user directly from persistent store. additionally support service accounts properly, reloaded from etcd during watch() - this was missing This PR is also half way remedy for minio#11305
harshavardhana
force-pushed
the
fix-etcd-config
branch
from
January 25, 2021 22:44
8ebabdd
to
49f850d
Compare
Mint Automation
11339-49f850d/mint-gateway-azure.sh.log:
Deleting image on docker hub |
harshavardhana
requested review from
nitisht and
Praveenrajmani
and removed request for
donatello and
vadmeste
January 26, 2021 02:38
nitisht
approved these changes
Jan 26, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: load credentials from etcd directly when possible
Motivation and Context
under large deployments loading credentials might be
time consuming, while this is okay and we will not
respond quickly for
mc admin user list
like queriesbut it is possible to support
mc admin user info
just like how we handle authentication by fetching
the user directly from persistent store.
additionally support service accounts properly,
reloaded from etcd during watch() - this was missing
This PR is also half way remedy for #11305
How to test this PR?
Remember to restart the server and then attempt
mc admin user info
on oneof the users, this should work instantaneously as we read directly from cred
store while users are loading in the background.
Types of changes
Checklist:
commit-id
orPR #
here)