New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix replication regression #11356
Merged
Merged
Fix replication regression #11356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Jan 26, 2021
poornas
force-pushed
the
fixrepl-reg
branch
2 times, most recently
from
January 26, 2021 22:04
f3b2c8f
to
36a3959
Compare
poornas
force-pushed
the
fixrepl-reg
branch
2 times, most recently
from
January 27, 2021 00:34
a9d4fef
to
d57ba57
Compare
harshavardhana
approved these changes
Jan 27, 2021
vadmeste
reviewed
Jan 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions, but tested and it works
From PR minio#11165 due to incorrect proxying for 2 way replication even when the object was not yet replicated Also fixing metadata comparisons when deciding to do full replication vs metadata copy. Also Fixes minio#11340
vadmeste
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & tested
Mint Automation
11356-941f750/mint-gateway-azure.sh.log:
Deleting image on docker hub |
harshavardhana
pushed a commit
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PR #11165 due to incorrect
proxying for 2 way replication even
when the object was not yet replicated
Also fixing metadata comparisons when
deciding to do full replciation vs metadata copy.
Also Fixes #11340
Description
Motivation and Context
How to test this PR?
Turn on 2 way replication and do some uploads to source.
mc admin trace
should show a PUT operation on the dest, not a COPY in master due to incorrect proxying.Types of changes
Checklist:
commit-id
orPR #
here)