-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow delete marker replication from replica #11566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Feb 18, 2021
harshavardhana
requested changes
Feb 18, 2021
@poornas tests need to be fixed
|
in the case of active-active replication. This PR also has following changes: - add docs on replication design - fix corner case of completing versioned delete on a delete marker when target is down and `mc rm --vid` is performed repeatedly. Instead the version should still be retained in `PENDING|FAILED` state until replication sync completes. - Remove `s3:Replication:OperationCompletedReplication` and `s3:Replication:OperationFailedReplication` from ObjectCreated events type
Mint Automation
11566-a064032/mint-compress-encrypt-dist-erasure.sh.log:
Deleting image on docker hub |
harshavardhana
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the case of active-active replication.
This PR also has following changes:
when target is down and
mc rm --vid
is performed repeatedly. Insteadthe version should still be retained in
PENDING|FAILED
state untilreplication sync completes.
s3:Replication:OperationCompletedReplication
ands3:Replication:OperationFailedReplication
from ObjectCreated eventstype
Description
Motivation and Context
In active-active replication, allowing delete marker replication from replica back to source is better as object state would be out of sync if this is not permitted.Added a note to documentation about limitation w.r.t duplicate delete markers if source and target both set delete markers concurrently
How to test this PR?
Types of changes
Checklist:
commit-id
orPR #
here)