-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDAP config: fix substitution variables #11586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In username search filter and username format variables we support %s for replacing with the username. - In group search filter we support %s for username and %d for the full DN of the username.
Mint Automation
11586-63b446b/mint-compress-encrypt-dist-erasure.sh.log:
Deleting image on docker hub |
harshavardhana
approved these changes
Feb 20, 2021
aead
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In username search filter and username format variables we support %s for
replacing with the username.
In group search filter we support %s for username and %d for the full DN of
the username.
Updates documentation as well.
Motivation and Context
In LDAP configuration, for group search we sometimes need to be able to substitute in the username or the full user DN to find the groups of a user. We allow this now in this change. In the existing implementation
%s
was substituted with the DN in the group search filter and with the username in the user search filter/format variables. This change also makes it uniform so that%s
is always replaced with the username and introduces%d
(for group search filter) to replace with the full user DN.How to test this PR?
With LDAP setup e.g. https://github.com/donatello/minio-ldap-testing
Types of changes
Checklist:
commit-id
orPR #
here)