-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update minio-go to fix an issue with S3 gateway #11591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we have changed our default envs to MINIO_ROOT_USER, MINIO_ROOT_PASSWORD this was not supported by minio-go credentials package, update minio-go to v7.0.10 for this support. This also addresses few bugs related to users had to specify AWS_ACCESS_KEY_ID as well to authenticate with their S3 backend if they only used MINIO_ROOT_USER.
harshavardhana
force-pushed
the
fix-bugs
branch
from
February 20, 2021 08:15
040265b
to
8bd14f7
Compare
Mint Automation
11591-8bd14f7/mint-compress-encrypt-dist-erasure.sh.log:
Deleting image on docker hub |
vadmeste
approved these changes
Feb 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: update minio-go to fix an issue with S3 gateway
Motivation and Context
since we have changed our default envs to MINIO_ROOT_USER,
MINIO_ROOT_PASSWORD this was not supported by minio-go
credentials package, update minio-go to v7.0.10 for this
support. This also addresses few bugs related to users
had to specify AWS_ACCESS_KEY_ID as well to authenticate
with their S3 backend if they only used MINIO_ROOT_USER.
How to test this PR?
Run s3 gateway against any S3 instance with MINIO_ROOT_USER
specified.
Types of changes
Checklist:
commit-id
orPR #
here)