-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: read metadata in O_DIRECT if configured and supported #11594
Merged
harshavardhana
merged 1 commit into
minio:master
from
harshavardhana:read-metadata-odirect
Feb 22, 2021
Merged
fix: read metadata in O_DIRECT if configured and supported #11594
harshavardhana
merged 1 commit into
minio:master
from
harshavardhana:read-metadata-odirect
Feb 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested review from
klauspost,
vadmeste,
krishnasrinivas and
poornas
February 21, 2021 02:16
reduce the page-cache pressure completely by moving the entire read-phase of our operations to O_DIRECT, primarily this is going to be very useful for chatty metadata operations such as listing, scanner, ilm, healing like operations to avoid filling up the page-cache upon repeated runs.
harshavardhana
force-pushed
the
read-metadata-odirect
branch
from
February 21, 2021 09:25
449e940
to
15111fd
Compare
Mint Automation
11594-15111fd/mint-compress-encrypt-dist-erasure.sh.log:
Deleting image on docker hub |
krishnasrinivas
approved these changes
Feb 22, 2021
vadmeste
reviewed
Feb 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, LGTM otherwise.
vadmeste
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: read metadata in O_DIRECT if configured and supported
Motivation and Context
reduce the page-cache pressure completely by moving
the entire read-phase of our operations to O_DIRECT,
primarily this is going to be very useful for chatty
metadata operations such as listing, scanner, ILM, healing
like operations to avoid filling up the page-cache upon
repeated runs.
How to test this PR?
Not trivial, requires a beefy setup.
Types of changes
Checklist:
commit-id
orPR #
here)