New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kms: replace KES client implementation with minio/kes #12207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
May 4, 2021
aead
force-pushed
the
kms-kes-client
branch
2 times, most recently
from
May 4, 2021 16:43
c48dcd6
to
d1f1f81
Compare
harshavardhana
approved these changes
May 4, 2021
please fix the conflicts @aead |
aead
force-pushed
the
kms-kes-client
branch
3 times, most recently
from
May 4, 2021 18:28
f02a8be
to
dd050b3
Compare
harshavardhana
requested changes
May 6, 2021
aead
force-pushed
the
kms-kes-client
branch
3 times, most recently
from
May 6, 2021 23:34
ea7ddca
to
81dfb1d
Compare
This commit replaces the custom KES client implementation with the KES SDK from https://github.com/minio/kes The SDK supports multi-server client load-balancing and request retry out of the box. Therefore, this change reduces the overall complexity within the MinIO server and there is no need to maintain two separate client implementations. Signed-off-by: Andreas Auernhammer <aead@mail.de>
harshavardhana
approved these changes
May 10, 2021
PTAL @Alevsk |
Mint Automation
12207-008712a/mint-compress-encrypt-dist-erasure.sh.log:
Deleting image on docker hub |
Alevsk
approved these changes
May 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit replaces the custom KES client implementation
with the KES SDK from https://github.com/minio/kes
The SDK supports multi-server client load-balancing and
request retry out of the box. Therefore, this change reduces
the overall complexity within the MinIO server and there
is no need to maintain two separate client implementations.
Motivation and Context
KMS, KES
How to test this PR?
Types of changes
Checklist:
commit-id
orPR #
here)