-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tiering] Support remote tiers with object versioning #12342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
reviewed
May 21, 2021
donatello
force-pushed
the
ilm-versioned-remote
branch
3 times, most recently
from
May 24, 2021 21:29
5cf7a62
to
9539106
Compare
klauspost
approved these changes
May 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (though more people should take a look)
donatello
force-pushed
the
ilm-versioned-remote
branch
2 times, most recently
from
May 27, 2021 20:54
87b2a6d
to
bcae3e8
Compare
Updated test instructions and fixed a bug. |
krisis
reviewed
May 27, 2021
donatello
force-pushed
the
ilm-versioned-remote
branch
from
May 27, 2021 22:54
b2a884d
to
f76bb69
Compare
- Adds versioning support for S3 based remote tiers that have versioning enabled. This ensure that when reading or deleting we specify the specific version ID of the object. In case of deletion this is important to ensure that the object version is actually deleted instead of simply being marked for deletion. - Stores the remote object's version id in the tier-journal. Tier-journal file version is not bumped up as serializing the new jentry struct version is compatible with old journals containing jentry's without the remote object version id. - `storageRESTVersion` is bumped up as FileInfo struct now includes a `TransitionRemoteVersionID` member. - Azure and GCS support for this feature will be added subsequently.
Co-authored-by: Krishnan Parthasarathi <krisis@users.noreply.github.com>
donatello
force-pushed
the
ilm-versioned-remote
branch
from
May 27, 2021 22:54
f76bb69
to
ce94acb
Compare
krisis
approved these changes
May 27, 2021
Mint Automation
12342-ce94acb/mint-compress-encrypt-dist-erasure.sh.log:
Deleting image on docker hub |
harshavardhana
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds versioning support for S3 based remote tiers that have versioning
enabled. This ensure that when reading or deleting we specify the specific
version ID of the object. In case of deletion this is important to ensure that
the object version is actually deleted instead of simply being marked for
deletion.
Stores the remote object's version id in the tier-journal. Tier-journal file
version is bumped up to support this change.
Azure and GCS support for versioning to be added subsequently.
How to test this PR?
myminio
instance:reminio
instance:myminio
:Observe that in some time the object is transitioned to remote (with
mc stat
).Then delete the local object with
mc rm --version-id VER_ID myminio/testbucket/bigobj
and in some time (in about 30+ minutes), the remote is deleted as well (not just having a delete marker created).Types of changes
Checklist:
commit-id
orPR #
here)