-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redact sensitive values from config in health data #12421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The health api returns the server configuration details. Redact sensitive values from the config values like URLs and credentials.
anjalshireesh
force-pushed
the
health-config
branch
from
June 2, 2021 13:21
d78e529
to
3f21dd5
Compare
Mint Automation
12421-3f21dd5/mint-compress-encrypt-dist-erasure.sh.log:
Deleting image on docker hub |
harshavardhana
requested changes
Jun 2, 2021
harshavardhana
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ❤️
klauspost
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The health api returns the server configuration details. Redact
sensitive values from the config values like URLs and credentials.
Motivation and Context
Prevent sensitive info from leaking out through healthinfo api
How to test this PR?
notify_webhook
mc admin subnet health {alias}
*redacted*
in the generated reportTypes of changes
Checklist:
commit-id
orPR #
here)