fix: serve always only the latest objects #12487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
reviewed
Jun 10, 2021
harshavardhana
force-pushed
the
serve-latest
branch
3 times, most recently
from
7195ae1
to
93f0e4a
Compare
harshavardhana
force-pushed
the
serve-latest
branch
from
93f0e4a
to
df99a31
Compare
1 task
due to a historic bug, it is possible that some objects might exist on multiple pools, rely on ModTime to return the correct pool.
harshavardhana
force-pushed
the
serve-latest
branch
from
df99a31
to
f98b8bf
Compare
Mint Automation
|
klauspost
added a commit
to klauspost/minio
that referenced
this pull request
Jun 14, 2021
Fix in minio#12487 assumes that slices with tiebreaks are sorted equally. That is only the case for "stable" sort versions. Fixes nil result being returned in multi-pool setups.
2 tasks
klauspost
added a commit
to klauspost/minio
that referenced
this pull request
Jun 14, 2021
Fix in minio#12487 assumes that slices with tiebreaks are sorted equally. That is only the case for "stable" sort versions. Fixes nil result being returned in multi-pool setups.
harshavardhana
pushed a commit
that referenced
this pull request
Jun 14, 2021
Fix in #12487 assumes that slices with tiebreaks are sorted equally. That is only the case for "stable" sort versions. Fixes nil result being returned in multi-pool setups.
harshavardhana
pushed a commit
that referenced
this pull request
Jun 14, 2021
Fix in #12487 assumes that slices with tiebreaks are sorted equally. That is only the case for "stable" sort versions. Fixes nil result being returned in multi-pool setups.
harshavardhana
pushed a commit
that referenced
this pull request
Jun 14, 2021
Fix in #12487 assumes that slices with tiebreaks are sorted equally. That is only the case for "stable" sort versions.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: serve always only the latest objects
Motivation and Context
due to a historic bug, it is possible that
some objects might exist on multiple pools,
rely on ModTime to return the correct pool.
How to test this PR?
Create two distributed setups and then
combine them by creating duplicate objects
Types of changes
Checklist:
commit-idorPR #here)