Improve multipart upload #12514
Merged
Improve multipart upload #12514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each multipart upload is holding a read lock for the entire upload duration of each part. This makes it impossible for other parts to complete until all currently uploading parts have released their locks. It will also make it impossible for new parts to start as long as on write lock is still being requested, essentially deadlocking uploads until all that may have been granted a read lock has completed. Refactor to only hold the upload id lock while reading and writing the metadata, but hold a part id lock while the part is being uploaded.
harshavardhana
approved these changes
Jun 16, 2021
harshavardhana
requested changes
Jun 16, 2021
harshavardhana
approved these changes
Jun 16, 2021
Mint Automation
|
vadmeste
reviewed
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Each multipart upload is holding a read lock for the entire upload duration of each part.
This makes it impossible for other parts to complete until all currently uploading parts have released their locks.
It will also make it impossible for new parts to start as long as on write lock is still being requested, essentially deadlocking uploads until all that may have been granted a read lock has completed.
Refactor to only hold the upload id lock while reading and writing the metadata, but hold a part id lock while the part is being uploaded.
Possible improvement for #12472
How to test this PR?
Single multipart uploads, with limited connection throughput.
Types of changes