-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDP:LDAP] Cleanup creds for removed LDAP user entries #12759
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change lets the server poll the LDAP service periodically to check for LDAP accounts with associated MinIO access credentials that have been removed. It deletes any access credentials for such removed LDAP users.
harshavardhana
requested changes
Jul 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested
Mint Automation
|
harshavardhana
approved these changes
Jul 21, 2021
kannappanr
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change lets the server poll the LDAP service periodically to check for LDAP
accounts with associated MinIO access credentials that have been removed. It
deletes any access credentials for such removed LDAP users.
Motivation and Context
Remove credentials for users no longer part of the LDAP org.
How to test this PR?
Use https://github.com/donatello/minio-ldap-testing to setup a test ldap server. Create some credentials for a user and delete the ldap entry using
ldapdelete
(see readme). After about 5 minutes, the credentials will be automatically purged.Types of changes
Checklist:
commit-id
orPR #
here)