DEPRECATION Warning: Avoid configuring default LDAP STS Expiry #12781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatello
changed the title
donatello
force-pushed
the
deprecate-ldap-expiry
branch
from
c0317e4
to
e20e449
Compare
harshavardhana
requested changes
Jul 22, 2021
- Show a notice when `MINIO_IDENTITY_LDAP_STS_EXPIRY` or the corresponding configuration option is used at server startup. - Once support is removed, the default will be fixed at 1 hour. - Users may specify expiry directly in the STS API. - Update docs and help message - Adds example in ldap.go to configure expiry in STS API.
donatello
force-pushed
the
deprecate-ldap-expiry
branch
from
aae8355
to
2f82681
Compare
Mint Automation
|
harshavardhana
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show a notice when
MINIO_IDENTITY_LDAP_STS_EXPIRYor the correspondingconfiguration option is used at server startup.
Once support is removed, the default will be fixed at 1 hour.
Users may specify expiry directly in the STS API.
Adds example in ldap.go to configure expiry in STS API.
Motivation and Context
The parameter is now redundant.
How to test this PR?
Use
docs/sts/ldap.go. Needs minio/minio-go#1521Types of changes
Checklist:
commit-idorPR #here)