Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase context timeout for bandwidth throttled reader #12820

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Jul 28, 2021

Fixes #12812

Description

Motivation and Context

Current timeout was at 10 minutes, increasing to an hour

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

@harshavardhana
Copy link
Member

Lint failures

golang.org/x/tools/cmd/stringer
Running lint check
internal/bucket/bandwidth/monitor.go:183:1: exported: exported method Monitor.IsThrottled should have comment or be unexported (revive)
func (m *Monitor) IsThrottled(bucket string) bool {
	m.tlock.RLock()
	defer m.tlock.RUnlock()
	_, ok := m.bucketThrottle[bucket]
	return ok
}
make: *** [Makefile:35: lint] Error 1
Error: Process completed with exit code 2.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poornas poornas force-pushed the fixctxt branch 2 times, most recently from 7f6422e to a4cf9d3 Compare July 28, 2021 21:21
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-zoned.sh ✔️
mint-gateway-nas.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit b6cd547 into minio:master Jul 28, 2021
@harshavardhana harshavardhana deleted the fixctxt branch July 28, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replication doesn't complete for big files
4 participants