allow multipart uploads for single part multipart #12821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
allow-multipart
branch
from
380a67b
to
e19d59e
Compare
its possible that some multipart uploads would have uploaded only single parts so relying on `len(o.Parts)` alone is not sufficient, we need to look for ETag pattern to be absolutely sure.
harshavardhana
force-pushed
the
allow-multipart
branch
from
e19d59e
to
b7f1a9b
Compare
Mint Automation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
allow multipart uploads for single part multipart
Motivation and Context
it's possible that some multipart uploads would have
uploaded only single parts so relying on
len(o.Parts)alone is not sufficient, we need to look for ETag
pattern to be absolutely sure.
How to test this PR?
Upload a single part multipart object, replication would
copy single part multipart object as non-multipart in the
master code.
Types of changes
Checklist:
commit-idorPR #here)