Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/logger hook init issue #13180

Merged
merged 6 commits into from
Sep 10, 2021

Conversation

4406arthur
Copy link
Contributor

Description

when I hook to elasticsearch endpoint the http respond code is 201, we should extend more statusCode on init case.

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

@vadmeste
Copy link
Member

Thanks @4406arthur

when I hook to elasticsearch endpoint the http respond code is 201, we should extend more statusCode on init case.

Is there any link of the spec which confirms this ?

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling errors and simplifications.

internal/logger/target/http/http.go Outdated Show resolved Hide resolved
internal/logger/target/http/http.go Outdated Show resolved Hide resolved
internal/logger/target/http/http.go Outdated Show resolved Hide resolved
internal/logger/target/http/http.go Outdated Show resolved Hide resolved
internal/logger/target/http/http.go Outdated Show resolved Hide resolved
Co-authored-by: Klaus Post <klauspost@gmail.com>
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. There was one mistake left.

I don't really see how this can hurt.

internal/logger/target/http/http.go Outdated Show resolved Hide resolved
@4406arthur
Copy link
Contributor Author

Thanks @4406arthur

when I hook to elasticsearch endpoint the http respond code is 201, we should extend more statusCode on init case.

Is there any link of the spec which confirms this ?

officially doc did not clearly statement status code part
https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-index_.html

but you can ref the discuss
https://discuss.elastic.co/t/best-way-to-check-a-document-has-been-indexed/20863

Co-authored-by: Klaus Post <klauspost@gmail.com>
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-zoned.sh ✔️
mint-gateway-nas.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit 2807c11 into minio:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants