Allow root user to create service accounts in LDAP #13221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
approved these changes
Sep 16, 2021
donatello
force-pushed
the
fix-svc-acc
branch
from
3db6cda
to
988927f
Compare
harshavardhana
requested changes
Sep 16, 2021
harshavardhana
approved these changes
Sep 16, 2021
vadmeste
reviewed
Sep 17, 2021
Alevsk
suggested changes
Sep 17, 2021
There was a problem hiding this comment.
When I try to create a service account with a regular LDAP user im getting:
API: AddServiceAccount()
Time: 16:47:37 PDT 09/17/2021
DeploymentID: 80b6f8b8-a28d-4c38-a584-b8b30eb4206c
RequestID: 16A5C0D42602B440
RemoteHost: ::1
Host: localhost:9000
UserAgent: MinIO (darwin; amd64) madmin-go/0.0.1
Error: Unable to find user DN: User DN for JM6HTMPWNB83U0XROM0V not found (*fmt.wrapError)
5: github.com/Alevsk/minio/cmd/api-errors.go:2039:cmd.toAPIErrorCode()
4: github.com/Alevsk/minio/cmd/admin-handler-utils.go:170:cmd.toAdminAPIErrCode()
3: github.com/Alevsk/minio/cmd/admin-handler-utils.go:157:cmd.toAdminAPIErr()
2: github.com/Alevsk/minio/cmd/admin-handlers-users.go:558:cmd.adminAPIHandlers.AddServiceAccount()
1: net/http/server.go:2049:http.HandlerFunc.ServeHTTP()
- Additionally, fix a bug in service account creation for LDAP users: the ldap short username was not associated with the service account.
donatello
force-pushed
the
fix-svc-acc
branch
from
988927f
to
f5c69b4
Compare
|
Thanks for testing @Alevsk - I've fixed the issue. I've redone the PR to make all cases clear again with comments. Please re-review @harshavardhana @vadmeste @Alevsk |
Mint Automation
|
Alevsk
approved these changes
Sep 20, 2021
harshavardhana
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
To prepare to allow creation of system service accounts for upcoming features.
How to test this PR?
Use mc and a test ldap setup.
Types of changes
Checklist:
commit-idorPR #here)