de-couple walkMu and walkReadMu for some granularity #13231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
harshavardhana
commented
Sep 17, 2021
harshavardhana
force-pushed
the
remove-lock
branch
from
e554465
to
5f9d922
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
harshavardhana
force-pushed
the
remove-lock
branch
from
5f9d922
to
bf6ff26
Compare
harshavardhana
changed the title
harshavardhana
changed the title
This commit brings two locks instead of single lock for WalkDir() calls on top of c25816e. The main reason is to avoid contention between readMetadata() and ListDir() calls, ListDir() can take time on prefixes that are huge for readdir() but this shouldn't end up blocking all readMetadata() operations, this allows for more room for I/O while not overly penalizing all listing operations.
harshavardhana
force-pushed
the
remove-lock
branch
from
bf6ff26
to
437b966
Compare
Mint Automation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
de-couple walkMu and walkReadMu for some granularity
Motivation and Context
This commit brings two locks instead of single lock for
WalkDir() calls on top of c25816e.
The main reason is to avoid contention between readMetadata()
and ListDir() calls, ListDir() can take time on prefixes that
are huge for readdir() but this shouldn't end up blocking
all readMetadata() operations, this allows for more room for
I/O while not overly penalizing all listing operations.
How to test this PR?
Nothing special, everything should work as expected.
Types of changes
Checklist:
commit-idorPR #here)