add gocritic/ruleguard checks back again, cleanup code. #13665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested review from
poornas,
donatello,
krisis,
vadmeste and
klauspost
harshavardhana
force-pushed
the
fix-bucket
branch
from
d2fb945
to
a7e9b79
Compare
donatello
reviewed
Nov 16, 2021
yes sure @donatello |
- remove some duplicated code - reported a bug, separately fixed in minio#13664 - using strings.ReplaceAll() when needed - using filepath.ToSlash() use when needed - remove all non-Go style comments from the codebase
harshavardhana
force-pushed
the
fix-bucket
branch
from
a7e9b79
to
680ad5d
Compare
donatello
requested changes
Nov 16, 2021
Co-authored-by: Aditya Manthramurthy <donatello@users.noreply.github.com>
Mint Automation
|
klauspost
approved these changes
Nov 16, 2021
krisis
approved these changes
Nov 16, 2021
poornas
approved these changes
Nov 16, 2021
7 tasks
rbuchnajzer
pushed a commit
to rbuchnajzer/minio
that referenced
this pull request
Dec 7, 2021
- remove some duplicated code - reported a bug, separately fixed in minio#13664 - using strings.ReplaceAll() when needed - using filepath.ToSlash() use when needed - remove all non-Go style comments from the codebase Co-authored-by: Aditya Manthramurthy <donatello@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add gocritic/ruleguard checks back again, cleanup code.
Motivation and Context
How to test this PR?
Nothing should change just code-reorg
Types of changes
Checklist:
commit-idorPR #here)