Add configurable channel queue_size for audit/logger webhook targets #13819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also log all the missed events and logs instead of silently swallowing the events. Bonus: Extend the logger webhook to support mTLS similar to audit webhook target.
harshavardhana
force-pushed
the
audit-queue-size
branch
from
f525aa7
to
bfd320b
Compare
Mint Automation
|
klauspost
approved these changes
Dec 3, 2021
yes there is a need but going to make our httpLogger concurrency friendly by adding more workers, currently its serialized - adding more workers would help here. |
poornas
approved these changes
Dec 3, 2021
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
Mar 15, 2022
PR introduced in minio#13819 was incorrect and was not handling the situation where a buffer is full can cause incessant amount of logs that would keep the logger webhook overrun by the requests. To avoid this only log failures to console logger instead of all targets as it can cause self reference, leading to an infinite loop.
7 tasks
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
Mar 15, 2022
PR introduced in minio#13819 was incorrect and was not handling the situation where a buffer is full can cause incessant amount of logs that would keep the logger webhook overrun by the requests. To avoid this only log failures to console logger instead of all targets as it can cause self reference, leading to an infinite loop.
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
Mar 15, 2022
PR introduced in minio#13819 was incorrect and was not handling the situation where a buffer is full can cause incessant amount of logs that would keep the logger webhook overrun by the requests. To avoid this only log failures to console logger instead of all targets as it can cause self reference, leading to an infinite loop.
harshavardhana
added a commit
that referenced
this pull request
Mar 16, 2022
PR introduced in #13819 was incorrect and was not handling the situation where a buffer is full can cause incessant amount of logs that would keep the logger webhook overrun by the requests. To avoid this only log failures to console logger instead of all targets as it can cause self reference, leading to an infinite loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add configurable channel queue_size for audit/logger webhook targets
Motivation and Context
Also, log all the missed events and logs instead of silently
swallowing the events.
Bonus: Extend the logger webhook to support mTLS
similar to audit webhook target.
How to test this PR?
Build locally and run
Types of changes
Checklist:
commit-idorPR #here)