Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix healing of replication delete markers #13933

Merged
merged 1 commit into from Dec 16, 2021

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Dec 16, 2021

A corner case can occur where delete marker was propagated but the
metadata could not be updated on primary. Sending a RemoveObject
call with the Delete marker version would end up permanently deleting
the version on target. Instead, perform a Stat on the DM
version on target and redo replication only if the DM is missing on
target.

Description

Motivation and Context

How to test this PR?

Need to synthetically induce error by skipping the metadata update in delete replication.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

A corner case can occur where delete marker was propagated but the
metadata could not be updated on primary. Sending a RemoveObject
call with the Delete marker version would end up permanently deleting
the version on target. Instead, perform a Stat on the DM
version on target and redo replication only if the DM is missing on
target.
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-gateway-nas.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit e270ab6 into minio:master Dec 16, 2021
@harshavardhana harshavardhana deleted the master-dbug branch December 16, 2021 23:34
@bh4t bh4t added the bugfix label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants