Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for drive speedtest #14182

Merged
merged 1 commit into from
Feb 2, 2022
Merged

add support for drive speedtest #14182

merged 1 commit into from
Feb 2, 2022

Conversation

wlan0
Copy link
Contributor

@wlan0 wlan0 commented Jan 26, 2022

Need to merge dperf and madmin-go before merging this

@wlan0
Copy link
Contributor Author

wlan0 commented Jan 28, 2022

@harshavardhana I've updated the PR after madmin-go and dperf merges. It is ready for review/merge

go.mod Outdated Show resolved Hide resolved
@harshavardhana
Copy link
Member

@wlan0 PTAL at linter errors

Error: cmd/notification.go:1614:1: exported: comment on exported method NotificationSys.DriveSpeedTest should be of the form "DriveSpeedTest ..." (revive)
// driveSpeedTest - Drive performance information
^

@harshavardhana
Copy link
Member

@wlan0 can you fix linter errors?

Running lint check
Error: cmd/notification.go:1614:1: exported: comment on exported method NotificationSys.DriveSpeedTest should be of the form "DriveSpeedTest ..." (revive)
// driveSpeedTest - Drive performance information
^
make: *** [Makefile:37: lint] Error 1
Error: Process completed with exit code 2.

cmd/admin-handlers.go Outdated Show resolved Hide resolved
cmd/admin-handlers.go Outdated Show resolved Hide resolved
cmd/admin-handlers.go Outdated Show resolved Hide resolved
cmd/peer-rest-common.go Show resolved Hide resolved
cmd/speedtest.go Outdated Show resolved Hide resolved
cmd/notification.go Outdated Show resolved Hide resolved
cmd/notification.go Show resolved Hide resolved
cmd/notification.go Outdated Show resolved Hide resolved
@harshavardhana
Copy link
Member

@wlan0 you would have to run

cmd/notification.go:1636: File is not gofumpt-ed (gofumpt)

https://github.com/mvdan/gofumpt

cmd/notification.go Outdated Show resolved Hide resolved
cmd/speedtest.go Show resolved Hide resolved
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-gateway-nas.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit d7df6bc into minio:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants