Optimize read locker cleanup #14200
Merged
Optimize read locker cleanup #14200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When objects hold a lot of read locks cleanup time grows exponentially.
```
BEFORE:
Unable to complete tests.
AFTER:
=== RUN Test_localLocker_expireOldLocksExpire/100-locks/1-read
local-locker_test.go:298: Scan Took: 0s. Left: 100/100
local-locker_test.go:317: Expire 50% took: 0s. Left: 44/44
local-locker_test.go:331: Expire rest took: 0s. Left: 0/0
=== RUN Test_localLocker_expireOldLocksExpire/100-locks/100-read
local-locker_test.go:298: Scan Took: 0s. Left: 10000/100
local-locker_test.go:317: Expire 50% took: 1ms. Left: 5000/100
local-locker_test.go:331: Expire rest took: 1ms. Left: 0/0
=== RUN Test_localLocker_expireOldLocksExpire/100-locks/1000-read
local-locker_test.go:298: Scan Took: 2ms. Left: 100000/100
local-locker_test.go:317: Expire 50% took: 55ms. Left: 50038/100
local-locker_test.go:331: Expire rest took: 29ms. Left: 0/0
=== RUN Test_localLocker_expireOldLocksExpire/10000-locks/1-read
local-locker_test.go:298: Scan Took: 1ms. Left: 10000/10000
local-locker_test.go:317: Expire 50% took: 2ms. Left: 5019/5019
local-locker_test.go:331: Expire rest took: 2ms. Left: 0/0
=== RUN Test_localLocker_expireOldLocksExpire/10000-locks/100-read
local-locker_test.go:298: Scan Took: 23ms. Left: 1000000/10000
local-locker_test.go:317: Expire 50% took: 160ms. Left: 499798/10000
local-locker_test.go:331: Expire rest took: 138ms. Left: 0/0
=== RUN Test_localLocker_expireOldLocksExpire/10000-locks/1000-read
local-locker_test.go:298: Scan Took: 200ms. Left: 10000000/10000
local-locker_test.go:317: Expire 50% took: 5.888s. Left: 5000196/10000
local-locker_test.go:331: Expire rest took: 3.417s. Left: 0/0
=== RUN Test_localLocker_expireOldLocksExpire/1000000-locks/1-read
local-locker_test.go:298: Scan Took: 133ms. Left: 1000000/1000000
local-locker_test.go:317: Expire 50% took: 348ms. Left: 500255/500255
local-locker_test.go:331: Expire rest took: 307ms. Left: 0/0
```
krisis
reviewed
Jan 27, 2022
Co-authored-by: Krishnan Parthasarathi <krisis@users.noreply.github.com>
krisis
approved these changes
Jan 27, 2022
Mint Automation
|
|
Looks like some legit issue at dsync |
Looks like a transient issue but it may be something to think about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When objects hold a lot of read locks cleanup time grows exponentially.
Cleanup now takes linear time no matter the distribution.
Close to being a bug fix, this has really bad worst case.
How to test this PR?
Test included. Only shows when you try to clean some of the objects.
Types of changes