Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore disk metrics for single drive mode #14212

Merged
merged 1 commit into from Jan 31, 2022

Conversation

harshavardhana
Copy link
Member

Description

ignore disk metrics for single drive mode

Motivation and Context

fixes #14211

How to test this PR?

~ curl https://localhost:9000/minio/v2/metrics/node

Can crash the single drive server setup with Prometheus.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-gateway-nas.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit b5d35c7 into minio:master Jan 31, 2022
@harshavardhana harshavardhana deleted the ignore-disk-metrics branch January 31, 2022 08:44
@bh4t bh4t added the bugfix label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV in github.com/prometheus/client_golang@v1.11.0/prometheus/registry.go:538
4 participants