Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quota usage as part of Prometheus metrics #14222

Merged
merged 1 commit into from Feb 1, 2022

Conversation

harshavardhana
Copy link
Member

Description

Add quota usage as part of Prometheus metrics

Motivation and Context

Bonus: pass caller context when needed to all
bucket metadata handling calls.

How to test this PR?

Enable quota and should see

~ curl -s https://localhost:9000/minio/v2/metrics/cluster |grep bucket_quota
# HELP minio_bucket_quota_total_bytes Total bucket quota size in bytes
# TYPE minio_bucket_quota_total_bytes gauge
minio_bucket_quota_total_bytes{bucket="testbucket",server="127.0.0.1:9000"} 1.073741824e+09

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

Bonus: pass caller context when needed to all
bucket metadata handling calls.
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-gateway-nas.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
{"detail": "Not found"}Deleting image locally

@harshavardhana harshavardhana merged commit 74faed1 into minio:master Feb 1, 2022
@harshavardhana harshavardhana deleted the add-quota-prome branch February 1, 2022 01:27
Sea-you pushed a commit to Sea-you/minio that referenced this pull request Feb 1, 2022
Bonus: pass caller context when needed to all bucket metadata handling calls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants