-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speedup getFormatErasureInQuorum use driveCount #14239
Merged
harshavardhana
merged 2 commits into
minio:master
from
harshavardhana:speed-up-reconnect
Feb 4, 2022
Merged
speedup getFormatErasureInQuorum use driveCount #14239
harshavardhana
merged 2 commits into
minio:master
from
harshavardhana:speed-up-reconnect
Feb 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
vadmeste
reviewed
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments
harshavardhana
force-pushed
the
speed-up-reconnect
branch
from
February 3, 2022 23:29
858f4e1
to
e9631a0
Compare
harshavardhana
changed the title
speedup getFormatErasureInQuorum use deployment ID
speedup getFormatErasureInQuorum use driveCount
Feb 3, 2022
startup speed-up, currently getFormatErasureInQuorum() would spend upto 2-3secs when there are 3000+ drives for example in a setup, simplify this implementation to use driveCounts.
harshavardhana
force-pushed
the
speed-up-reconnect
branch
from
February 3, 2022 23:41
e9631a0
to
d5c5415
Compare
klauspost
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor opt.
Co-authored-by: Klaus Post <klauspost@gmail.com>
Mint Automation
|
poornas
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
speedup getFormatErasureInQuorum use deployment ID
Motivation and Context
startup speed-up, currently getFormatErasureInQuorum()
would spend up to 2-3secs when there are 3000+ drives
for example in a setup, simplify this implementation
to use the drive counts.
How to test this PR?
Added benchmarks
Types of changes
Checklist:
commit-id
orPR #
here)