Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedup getFormatErasureInQuorum use driveCount #14239

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Feb 3, 2022

Description

speedup getFormatErasureInQuorum use deployment ID

Motivation and Context

startup speed-up, currently getFormatErasureInQuorum()
would spend up to 2-3secs when there are 3000+ drives
for example in a setup, simplify this implementation
to use the drive counts.

How to test this PR?

Added benchmarks

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

cmd/format-erasure.go Outdated Show resolved Hide resolved
@harshavardhana harshavardhana changed the title speedup getFormatErasureInQuorum use deployment ID speedup getFormatErasureInQuorum use driveCount Feb 3, 2022
startup speed-up, currently getFormatErasureInQuorum()
would spend upto 2-3secs when there are 3000+ drives
for example in a setup, simplify this implementation
to use driveCounts.
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor opt.

cmd/format-erasure.go Outdated Show resolved Hide resolved
Co-authored-by: Klaus Post <klauspost@gmail.com>
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-gateway-nas.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit 6123377 into minio:master Feb 4, 2022
@harshavardhana harshavardhana deleted the speed-up-reconnect branch February 4, 2022 20:21
@bh4t bh4t added the bugfix label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants