fix: quorum requirement for DeleteMarkers and parity upgraded objects #14248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeleteMarkers do not have a default quorum, i.e it is possible that DeleteMarkers were created with n/2+1 quorum as well to make sure that we satisfy situations such as those we need to make sure delete markers only expect n/2 read quorum. Additionally we should also look at additional metadata on the actual objects that might have been "erasure" upgraded with new parity when disks are down. In such a scenario do not default to the standard storage class parity, instead use the parityBlocks present on the FileInfo to ensure that we are dealing with the correct quorum for READs and DELETEs.
Mint Automation
|
klauspost
approved these changes
Feb 4, 2022
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
Feb 9, 2022
Deleting bulk objects had an issue since the relevant versionID is not passed through the layers to ensure that the dangling object purge actually works cleanly. This is a continuation of quorum related error returned by multi-object delete API from minio#14248 This PR ensures that we pass down correct information as well as extend the scope of dangling object detection.
7 tasks
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
Feb 9, 2022
Deleting bulk objects had an issue since the relevant versionID is not passed through the layers to ensure that the dangling object purge actually works cleanly. This is a continuation of quorum related error returned by multi-object delete API from minio#14248 This PR ensures that we pass down correct information as well as extend the scope of dangling object detection.
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
Feb 9, 2022
Deleting bulk objects had an issue since the relevant versionID is not passed through the layers to ensure that the dangling object purge actually works cleanly. This is a continuation of quorum related error returned by multi-object delete API from minio#14248 This PR ensures that we pass down correct information as well as extend the scope of dangling object detection.
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
Feb 9, 2022
Deleting bulk objects had an issue since the relevant versionID is not passed through the layers to ensure that the dangling object purge actually works cleanly. This is a continuation of quorum related error returned by multi-object delete API from minio#14248 This PR ensures that we pass down correct information as well as extend the scope of dangling object detection.
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
Feb 9, 2022
Deleting bulk objects had an issue since the relevant versionID is not passed through the layers to ensure that the dangling object purge actually works cleanly. This is a continuation of quorum related error returned by multi-object delete API from minio#14248 This PR ensures that we pass down correct information as well as extend the scope of dangling object detection.
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
Feb 9, 2022
Deleting bulk objects had an issue since the relevant versionID is not passed through the layers to ensure that the dangling object purge actually works cleanly. This is a continuation of quorum related error returned by multi-object delete API from minio#14248 This PR ensures that we pass down correct information as well as extend the scope of dangling object detection.
harshavardhana
added a commit
that referenced
this pull request
Feb 9, 2022
…s() (#14273) Deleting bulk objects had an issue since the relevant versionID is not passed through the layers to ensure that the dangling object purge actually works cleanly. This is a continuation of quorum related error returned by multi-object delete API from #14248 This PR ensures that we pass down correct information as well as extend the scope of dangling object detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: quorum requirement for DeleteMarkers and parity upgraded objects
Motivation and Context
DeleteMarkers do not have a default quorum, i.e it is possible that
DeleteMarkers were created with n/2+1 quorum as well to make sure
that we satisfy situations such as those we need to make sure delete
markers only expect n/2 read quorum.
Additionally, we should also look at additional metadata on the
actual objects that might have been "erasure" upgraded with new
parity when disks are down.
In such a scenario do not default to the standard storage class
parity, instead use the parityBlocks present on the FileInfo to
ensure that we are dealing with the correct quorum for READs and
DELETEs.
How to test this PR?
Few datasets are needed for example
inspect.324c74d9.zip
inspect.384b43df.zip
Without this fix, these objects shall return
503 quorumerror, however with this fix you shallsee they all succeeding.
Types of changes
Checklist:
commit-idorPR #here)