Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use madmin-go v1.3.1 #14250

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Use madmin-go v1.3.1 #14250

merged 2 commits into from
Feb 4, 2022

Conversation

anjalshireesh
Copy link
Contributor

Description

Use madmin-go v1.3.1

Motivation and Context

This version of madmin-go adds more information to the health report
specifically CPU frequency governor related information

How to test this PR?

  • Build minio with this PR and start a cluster using it
  • Build mc using the same version madmin-go
  • Generate a health report using this mc (mc admin subnet health {alias} --airgap)
  • Verify that the generated report contains a new node is_freq_gov_perf for each node under sys -> cpus

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

@anjalshireesh anjalshireesh marked this pull request as ready for review February 4, 2022 10:50
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-gateway-nas.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 778cccb into minio:master Feb 4, 2022
@anjalshireesh anjalshireesh deleted the subnet branch February 7, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants